Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider only the first primary URI of entities #288

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

gythaogg
Copy link
Contributor

where an entity might have more than one URI

primary URI is one that is in the same domain as
defined in APIS_BASE_URI in settings

the default value for APIS_BASE_URI is hardcoded to be consistent with the same value used in apis_entities at the time of the creation of the URI object

Resolves issue:

Checklist (Replace the space in square brackets with a lowercase x for all that apply)

  • [x ] My changes don't generate new warnings or errors
  • [x ] My changes follow the project's code formatting rules and style guidelines
  • I have commented my code with Docstrings and code comments, particularly complex, unusual or hard-to-read code
  • I have updated the project documentation to reflect the changes I introduce
  • I have added new unit tests or updated existing ones to demonstrate my changes works

@gythaogg gythaogg requested a review from b1rger September 20, 2023 07:37
Copy link
Contributor

@b1rger b1rger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format the commit message title according to the conventional commit standard. I.e. fix(apis_relations): fix entity lookup for multi URI entities

Please add Closes: #221 to the commit message body.

There are a couple of newlines removed from the file, those changes have nothing to do with the fix itself. Ideally those would be removed (Probably some setting from your editor?)

Other than that - LGTM!

@gythaogg gythaogg force-pushed the bugfix/allow_multiple_uris branch from 4838b68 to 019c6d8 Compare September 20, 2023 09:01
primary URI is one that is in the same domain as defined in
APIS_BASE_URI in settings. the default value for APIS_BASE_URI is
hardcoded to be consistent with the same value used in apis_entities at
the time of the creation of the URI object

Closes: #221
@b1rger b1rger force-pushed the bugfix/allow_multiple_uris branch from 019c6d8 to ff3c999 Compare September 26, 2023 08:03
@b1rger b1rger merged commit 0febd2a into main Sep 26, 2023
9 checks passed
@b1rger
Copy link
Contributor

b1rger commented Sep 26, 2023

Thanks!

@gythaogg gythaogg deleted the bugfix/allow_multiple_uris branch September 26, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants