Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(apis_metainfo)!: drop Source model #231

Merged
merged 1 commit into from
Oct 4, 2023
Merged

refactor(apis_metainfo)!: drop Source model #231

merged 1 commit into from
Oct 4, 2023

Conversation

b1rger
Copy link
Contributor

@b1rger b1rger commented Jun 29, 2023 •
edited
Loading

The Source model was introduced to store information about where an
entity was imported from. This can easily be replaced by a custom field
in the ontology. Therefore the Source model was removed.

Closes: #227

@b1rger b1rger force-pushed the birger/drop-source branch 3 times, most recently from e567466 to 6517278 Compare June 30, 2023 18:30
@b1rger b1rger marked this pull request as ready for review June 30, 2023 18:32
@b1rger b1rger requested a review from a team June 30, 2023 18:32
@b1rger b1rger force-pushed the birger/drop-source branch from 6517278 to 405f0cf Compare June 30, 2023 18:32
@b1rger b1rger changed the title feat(apis_metainfo): drop Source model feat(apis_metainfo)!: drop Source model Jun 30, 2023
@koeaw
Copy link
Contributor

koeaw commented Jul 3, 2023

Since we're using Source for Frischmuth and I won't have time to work on a replacement for it this week, I would ask that merging this be postponed until next week.

@sennierer sennierer marked this pull request as draft July 5, 2023 06:23
@sennierer
Copy link
Collaborator

given that @koeaw asked for postponing the merge convertged this to a draft for the moment

@b1rger b1rger force-pushed the birger/drop-source branch 3 times, most recently from 72b4f99 to d15cbc5 Compare September 21, 2023 07:05
@b1rger
Copy link
Contributor Author

b1rger commented Sep 21, 2023

2 months have passed. We do now have releases, so merging this would not interrupt downstream projects if they don't bump versions. Can we move this forward?

CC: @acdh-oeaw/prosnet

@b1rger b1rger added the needs-attention This issue or pull request is in need of discussion, information, assessment by team members label Sep 21, 2023
@b1rger b1rger marked this pull request as ready for review September 25, 2023 18:40
@sennierer sennierer added breaking-change Changes which may cause errors/failures without prior inspection/revision of other code or config and removed needs-attention This issue or pull request is in need of discussion, information, assessment by team members labels Oct 4, 2023
@b1rger b1rger force-pushed the birger/drop-source branch from d15cbc5 to d51907b Compare October 4, 2023 11:47
@b1rger b1rger changed the title feat(apis_metainfo)!: drop Source model refactor(apis_metainfo)!: drop Source model Oct 4, 2023
@b1rger
refactor(apis_metainfo)!: drop Source model
d51907b 
The `Source` model was introduced to store information about where an
entity was imported from. This can easily be replaced by a custom field
in the ontology. Therefore the `Source` model was removed.

Closes: #227
@b1rger b1rger merged commit e877213 into main Oct 4, 2023
6 checks passed
@b1rger b1rger deleted the birger/drop-source branch October 11, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking-change Changes which may cause errors/failures without prior inspection/revision of other code or config
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get rid of apis_metainfo.models.Source
3 participants
@b1rger @koeaw @sennierer