feat(generic): allow to disable pagination in table class #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of overriding the `get_paginate_by` method of the TableMixinBase, we now override the `get_table_pagination` method. This allows to also set the `table_pagination` setting in the table itself, therefore providing the means to disable the pagination alltogether. Closes: #1444
b1rger
force-pushed
the
birger/1444-table-pagination
branch
from
05f9ebf to
bd90a77
Compare
b1rger
changed the title
gythaogg
requested changes
Nov 27, 2024
There was a problem hiding this comment.
paginate_by = Noneor not set at all - page size is 25paginate_by = 10- page size is 10table_pagination = Noneor not set at all - page size is 25 or the value ofpaginate_bytable_pagination = False- pagination is disabledtable_pagination = Truethrows'bool' object is not iterableerror
Code change is approved but the PR should also go with the following change in documentation I think
Your table can also contain a paginate_by attribute, which is then used by the list view to determines the number of items per page, or None for no pagination (which is the default).
should be modified to something like
Your table can also contain a
paginate_byattribute, which is then used by the list view to determine the number of items per page. When this is not set, the page size defaults to 25. To disable pagination altogether, usetable_pagination = False.
gythaogg
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of overriding the
get_paginate_bymethod of theTableMixinBase, we now override the
get_table_paginationmethod. Thisallows to also set the
table_paginationsetting in the tableitself, therefore providing the means to disable the pagination
alltogether.
Closes: #1444