Refactor JavaScript inclusion #1277
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move <script> tag which embeds external Bootstrap 4 bundle from included partial template directly into base.html, place it before bootstrap-multiselect dependency, and remove partial.
Move <script> tag which embeds external HTMX package from script block at bottom of base.html template to block at top of file; add attributes for subresource integrity and CORS.
Add event listener for readystatechange to core.js.
Move jQuery config for multiselect widget to own function, drop $(document).ready() wrapper in favour of vanilla JS event listener, update comments.
koeaw
force-pushed
the
kk/refactor/inline_js
branch
from
47690ee to
935d5b1
Compare
Move event listener for XHTM swapping from internal script in base.html to external core.js file.
Add to, update formatting of existing comments on HTMX swap config.
Move internal script from included partial template backtotopbtn.html to external core.js file.
Improve wording, formatting of existing comments on scroll button JavaScript.
Set defer attribute on script tags for external scripts.
koeaw
force-pushed
the
kk/refactor/inline_js
branch
from
935d5b1 to
13ba98b
Compare
Reformat JavaScript in <script> tag mixed with template language syntax for readability. Includes conversion of comments formatted for JavaScript to Django template syntax.
koeaw
force-pushed
the
kk/refactor/inline_js
branch
from
c42f361 to
8a890b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves (most of) the existing internal JS to external files in an attempt to solve #1166.
Event listening for loading of static content is implemented via
readystatechangerather thanDOMContentLoadedorloadto allow for greater flexibility, also with regard to integrating jQuery (which does its own thing).The remaining internal JS is in
apis_relations. The last commit reformats abstractentity_form.html for readability.Tangentially related: the internal JS was recently moved from
apis_entitiestoapis_relations. It interacts with functions in apis_entities.js, which should probably be moved toapis_relations.jsinapis_relations(?!).