Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ms/1095 history user not recorded in history objects #1096

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

sennierer
Copy link
Collaborator

No description provided.

Copy link
Contributor

@b1rger b1rger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase ;)

docs/source/features.rst Outdated Show resolved Hide resolved
docs/source/features.rst Outdated Show resolved Hide resolved
docs/source/features.rst Outdated Show resolved Hide resolved
@b1rger
Copy link
Contributor

b1rger commented Oct 7, 2024

(I'm not sure if this is also something we want in our default settings - probably depends if we also want the apis_core.history app in the INSTALLED_APPS)

@sennierer
Copy link
Collaborator Author

given that this is recording user names I suggest to just add the comments in the documentation on how to use it

@sennierer
Copy link
Collaborator Author

(I'm not sure if this is also something we want in our default settings - probably depends if we also want the apis_core.history app in the INSTALLED_APPS)

lets discuss that in another issue

@sennierer sennierer force-pushed the ms/1095-history-user-not-recorded-in-history-objects branch from 71be747 to 9fb4551 Compare December 10, 2024 15:58
@sennierer sennierer requested a review from b1rger December 10, 2024 16:03
@sennierer
Copy link
Collaborator Author

@b1rger rebased it on main and added your suggested changes. I suggest to merge this and discuss whether to add it to default settings or not in another issue

@b1rger b1rger merged commit 4694885 into main Dec 11, 2024
15 checks passed
@b1rger b1rger deleted the ms/1095-history-user-not-recorded-in-history-objects branch December 11, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants