Skip to content

Commit

Permalink
chore(sample_project): drop apis_relation from INSTALLED_APPS
Browse files Browse the repository at this point in the history
We only use the new style relations in the sample project, so we can
drop the old ones. The `history` tests still depend on some parts of the
`apis_relations` module, so we introduce a separate settings file for
the tests that adds `apis_relations` to the `INSTALLED_APPS`.
  • Loading branch information
b1rger committed Dec 9, 2024
1 parent 3d53102 commit 5370269
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/django-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
pull_request:

env:
DJANGO_SETTINGS_MODULE: sample_project.settings
DJANGO_SETTINGS_MODULE: sample_project.settings_tests

jobs:
setup:
Expand Down
1 change: 0 additions & 1 deletion sample_project/settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@
# The APIS apps
"apis_core.relations",
"apis_core.apis_metainfo",
"apis_core.apis_relations",
"apis_core.apis_entities",
# apis_vocabularies is deprecated, but there are
# still migrations depending on it - it will be dropped
Expand Down
3 changes: 3 additions & 0 deletions sample_project/settings_tests.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
from .settings import *

INSTALLED_APPS += ["apis_core.apis_relations"] # noqa: F405

0 comments on commit 5370269

Please sign in to comment.