feat(markdown-docx): add softbreak transformer - #397 #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Softbreak Rule Check for softbreak in transformer and call rule Test for above(acceptance-of-delivery.json) Signed-off-by: k-kumar-01 <[email protected]>
algomaster99
suggested changes
Jun 18, 2021
| </w:r> | ||
| `; | ||
| }; | ||
| module.exports = { TEXT_RULE, EMPHASIS_RULE, HEADING_RULE, VARIABLE_RULE, SOFTBREAK_RULE }; |
There was a problem hiding this comment.
Insert a line break before this statement.
| }); | ||
| } | ||
| it(`should parse ${file.replace('.json', '')}.`, async () => { | ||
| await checkRoundTripEquality(`${directoryName}/${file}`); |
There was a problem hiding this comment.
Rename acceptance-of-delivery to have softbreak in its name. The test cases will be clearer as we don't know what nodes the former contains.
There was a problem hiding this comment.
@algomaster99
accpetance-of-delivery is also used in the OoxmlTransformer. So I didn't change the name. Should I create a new file for the softbreak?
There was a problem hiding this comment.
Creating a new file would be great. Thanks!
There was a problem hiding this comment.
@algomaster99 Done
Signed-off-by: k-kumar-01 <[email protected]>
algomaster99
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: k-kumar-01 [email protected]
Partial fix #397
Changes
Author Checklist
--signoffoption of git commit.masterfromfork:branchname