feat: add heading transformer - #397 #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heading transformer for CiceroMark->OOXML Roundtrip(CiceroMark <-> OOXML) test for above Signed-off-by: k-kumar-01 <[email protected]>
|
@algomaster99 PS: I will replace |
Comment on lines
+45
to
+57
| let textandHeadingCiceroMark = await fs.readFileSync( | ||
| 'test/data/ciceroMark/text-and-heading.json', | ||
| 'utf-8' | ||
| ); | ||
| // converts from string to JSON object | ||
| textandHeadingCiceroMark = JSON.parse(textandHeadingCiceroMark); | ||
|
|
||
| const ciceroMarkTransformer = new CiceroMarkToOOXMLTransfomer(); | ||
| const ooxml = ciceroMarkTransformer.toOOXML(textandHeadingCiceroMark); | ||
|
|
||
| const ooxmlTransformer = new OoxmlTransformer(); | ||
| const convertedObject = ooxmlTransformer.toCiceroMark(ooxml); | ||
| expect(convertedObject).to.deep.equal(textandHeadingCiceroMark); |
There was a problem hiding this comment.
The logic is similar to what you did for text and paragraph test. I think this can be reused but not in this PR. You can refactor this in a separate PR but do create an issue to keep track of it.
Sure. Keep this on priority. |
algomaster99
pushed a commit
that referenced
this pull request
Jun 17, 2021
Signed-off-by: k-kumar-01 <[email protected]>
algomaster99
pushed a commit
that referenced
this pull request
Jun 17, 2021
Signed-off-by: k-kumar-01 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: k-kumar-01 [email protected]
Partial improvement #397
Changes
Author Checklist
--signoffoption of git commit.masterfromfork:branchname