-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ILogger factory #809
ILogger factory #809
Conversation
NeedFileJoining needed to be changed to a bool
Add LastUpdatedBefore to the OrderList response, so it can be used as https://www.youtube.com/watch?v=aeSAo5a6ClQ
Can you solve the Conflict here |
i have updated the merge conflicts, if you are ok with the principle, i can update the rest of the services to have the logger passed through to them, this should be done before this is merged |
Yes it's ok you can do it |
@@ -154,38 +162,39 @@ private void SaveLastRequestHeader(IReadOnlyCollection<RestSharp.HeaderParameter | |||
|
|||
private void LogRequest(RestRequest request, RestResponse response) | |||
{ | |||
if (AmazonCredential.IsDebugMode) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since loggerFactory not added to all service its better to Keep IsDebugMode for now
this is just an initial exploration to adding an ILogger to the library, to improve what we can see from logging libraries etc, to make it less of a black box.
I have only done one service for now, but if this gets approval then i can add it to the other services