Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Radio Box Issues #90

Merged
merged 4 commits into from
Jan 16, 2024
Merged

Fix Radio Box Issues #90

merged 4 commits into from
Jan 16, 2024
+32 −21

Conversation

Coderwelsch
Copy link
Contributor

Description

This mr:

  • fixes a transparent bg issue with radio box options
  • improves classNames in radio box option
  • adds a className property to radio box options
  • BREAKING CHANGE: This mr adds a breaking change where the text-size class got removed

Checklist

  • Change increases quality
  • Change is validated by tests
  • Change is readable and easy to understand
  • Documentation is updated
  • Security impact has been considered
  • Changes validated in runtime

@linear Linear
Copy link

linear bot commented Jan 16, 2024

PLA-959 Replace Fancy Data Channel Stepper Component with RHF/Tailwind

@Coderwelsch Coderwelsch changed the title Pla 959 replace fancy data channel stepper component with Fix Radio Box Issues Jan 16, 2024
@Coderwelsch
Copy link
Contributor Author

Added white background to default radio options:

CleanShot 2024-01-16 at 10 49 35@2x

rodelta
rodelta approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@rodelta rodelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Coderwelsch Coderwelsch merged commit ddb7573 into main Jan 16, 2024
7 checks passed
@Coderwelsch Coderwelsch deleted the pla-959-replace-fancy-data-channel-stepper-component-with branch January 16, 2024 10:21
@abusix-bot
Copy link
Collaborator

🎉 This PR is included in version 3.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodelta rodelta rodelta approved these changes

Assignees

@Coderwelsch Coderwelsch

Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Coderwelsch @abusix-bot @rodelta