Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Z-Indices Issues with Dialog / Updated CI Node Version #78

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Fix: Z-Indices Issues with Dialog / Updated CI Node Version #78

merged 3 commits into from
Dec 19, 2023

Conversation

Coderwelsch
Copy link
Contributor

@Coderwelsch Coderwelsch commented Dec 18, 2023 •
edited
Loading

Description

This mr fixes z-index issues with dialog elements and bumps the ci node version to required v20

Checklist

  • Change increases quality
  • Change is validated by tests
  • Change is readable and easy to understand
  • Documentation is updated
  • Security impact has been considered
  • Changes validated in runtime

@linear Linear
Copy link

linear bot commented Dec 18, 2023

PLA-865 Fix: Wrong Z-Indexes in Portal

@Coderwelsch Coderwelsch changed the title Draft: fix: add z-50 to fix z-index problem with other elements Fix: add z-50 to fix z-index problem with other elements Dec 19, 2023
@Coderwelsch Coderwelsch changed the title Fix: add z-50 to fix z-index problem with other elements Fix: Z-Indices Issues with Dialog, Updqted CI Node Version Dec 19, 2023
@Coderwelsch Coderwelsch changed the title Fix: Z-Indices Issues with Dialog, Updqted CI Node Version Fix: Z-Indices Issues with Dialog / Updated CI Node Version Dec 19, 2023
rodelta
rodelta approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@rodelta rodelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks for fixing the node image thing!

@Coderwelsch Coderwelsch merged commit 2b319de into main Dec 19, 2023
5 checks passed
@Coderwelsch Coderwelsch deleted the pla-865-fix-wrong-z-indexes-in-portal branch December 19, 2023 14:34
@abusix-bot
Copy link
Collaborator

🎉 This PR is included in version 3.7.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodelta rodelta rodelta approved these changes

Assignees

@Coderwelsch Coderwelsch

Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Coderwelsch @abusix-bot @rodelta