Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NavigationPopoverOverlay): Add portal to overlay to send it to th… #77

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

pallendes
Copy link
Contributor

@pallendes pallendes commented Dec 15, 2023

Description

  • Offer more flexibility by exporting navigation overlay, allowing the client to deal with overlapping issues.
  • Change popover placement to be top-start

This fixes the overlapping issue by allowing the client to add a portal and send it to the beginning of the document (I already tested it using the next channel):
image

Checklist

  • Change increases quality
  • Change is validated by tests
  • Change is readable and easy to understand
  • Documentation is updated
  • Security impact has been considered
  • Changes validated in runtime

…e end of the document body / changed position of popover
Copy link

linear bot commented Dec 15, 2023

@pallendes pallendes merged commit 055f77a into main Dec 18, 2023
6 checks passed
@pallendes pallendes deleted the pla-911-fix-popover-overlay-overlapping branch December 18, 2023 07:12
@abusix-bot
Copy link
Collaborator

🎉 This PR is included in version 3.7.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants