BREAKING CHANGE: Remove width and height from dialog parent element #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnlfischer
requested review from
a team and
rodelta
and removed request for
a team
PLA-791 Fixed width for set up Dialog
Why?Less prone to strange resizing behaviour CleanShot 2023-11-06 at 16.34.42.png DescriptionSet the width to be fixed at 736px wide. This should be applied globally to all hailstorm dialog component. Notes[Extra important info that might be useful] |
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We removed the width and height of the dialog panel component since this is supported through the normal className prop. Beside that the dynamic props
are not working in production because it is no purgeable HTML.
We also increased the general width of the dialog.