feat(components): add support for anchor tag buttons #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnlfischer
requested review from
a team and
thomaswienecke
and removed request for
a team
PLA-828 Add anchor tag option to button
Why?We have some buttons used as anchor tags in new designs and we need to add that option to the button component. DescriptionUsing discriminated union in TS we are able to support previous button versions without creating a breaking change. Notes[Extra important info that might be useful] |
Coderwelsch
approved these changes
Nov 20, 2023
|
🎉 This PR is included in version 2.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are adding the "as"-prop to the button to support anchor tags styled as a normal button.
Note: need to bump up the version of tailwind prettier plugin since prettier has some breaking changes.