Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLA-764 Remove the default footer from the dialog component #54

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

rodelta
Copy link
Contributor

@rodelta rodelta commented Oct 27, 2023

Description

Remove the fallback buttons when not passing a footer, plus a style fix.
Expand storybook to see the dialog used with different options.

Checklist

  • Change increases quality
  • Change is validated by tests
  • Change is readable and easy to understand
  • Documentation is updated
  • Security impact has been considered
  • Changes validated in runtime

@linear
Copy link

linear bot commented Oct 27, 2023

PLA-764 Setup dialog footer fix

Why?

We want to show the buttons at the end of the dialog

Description

  • Modify the dialog component to support not passing the footer
  • Move the dialog implementation on the setup dialog to use the button at the end of the body

@rodelta rodelta changed the title Remove the default footer from the dialog component PLA-764 Remove the default footer from the dialog component Oct 27, 2023
@pallendes
Copy link
Contributor

Looking good 👌

@rodelta rodelta merged commit 16501df into main Oct 27, 2023
6 checks passed
@rodelta rodelta deleted the pla-764-setup-dialog-footer-fix branch October 27, 2023 13:30
@abusix-bot
Copy link
Collaborator

🎉 This PR is included in version 2.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants