Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(textarea): add minimum height #50

Merged
merged 3 commits into from
Oct 17, 2023
Merged

feat(textarea): add minimum height #50

merged 3 commits into from
Oct 17, 2023

Conversation

pallendes
Copy link
Contributor

Description

This PR adds minimum height to the textarea component

Checklist

  • Change increases quality
  • Change is validated by tests
  • Change is readable and easy to understand
  • Documentation is updated
  • Security impact has been considered
  • Changes validated in runtime

@linear
Copy link

linear bot commented Oct 17, 2023

PLA-727 Network management typo and UI fixes

  • Name in the sidebar is network management instead of networks management (Without the S)
  • The filters need a 8px gap between buttons

image.png

image.png

  • Description input should have a minimum of

image.png

rodelta
rodelta approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@rodelta rodelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@pallendes pallendes merged commit 657f9a8 into main Oct 17, 2023
5 checks passed
@pallendes pallendes deleted the pla-727-network-management-typo-and-ui-fixes branch October 17, 2023 08:33
@abusix-bot
Copy link
Collaborator

🎉 This PR is included in version 2.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodelta rodelta rodelta approved these changes

Assignees

@pallendes pallendes

Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pallendes @abusix-bot @rodelta