fix: remove unsupported ui-open class from Listbox button #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodelta
approved these changes
Jul 31, 2024
mnlfischer
deleted the
pla-1299-focus-state-on-listbox-is-wrong-in-dialogs
branch
|
🎉 This PR is included in version 5.6.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We remove the ui-open state that gets applied when a listbox is inside a model/dialog. The ui-open state is always
truewhen the outer dialog is in open state. This causes an always active ui-open state visually.https://headlessui.com/v1/react/listbox#focus-management
The focus state is intended to get trapped and ui-open is not supported on the Listbox.Button component.