Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TabPanel): Remove as={React.Fragment} prop #113

Conversation

pallendes
Copy link
Contributor

@pallendes pallendes commented Feb 21, 2024

Description

Remove the as={React.Fragment} prop, as this will throw a console error when headless ui attempts to pass down some basic HTML attributes.

Checklist

  • Change increases quality
  • Change is validated by tests
  • Change is readable and easy to understand
  • Documentation is updated
  • Security impact has been considered
  • Changes validated in runtime

Remove as={React.Fragment} prop, as this will throw a console error when headless ui attempt to pass down some basic html attributes
Copy link

linear bot commented Feb 21, 2024

@pallendes pallendes self-assigned this Feb 21, 2024
@pallendes pallendes requested a review from mnlfischer February 21, 2024 11:37
Copy link
Contributor

@mnlfischer mnlfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pallendes pallendes merged commit 37a518a into main Feb 21, 2024
7 checks passed
@pallendes pallendes deleted the pla-1049-investigate-console-error-attempts-to-access-this-ref-will branch February 21, 2024 11:38
@abusix-bot
Copy link
Collaborator

🎉 This PR is included in version 4.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants