chore(deps): upgrade ESLint to v9 #200
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #200 +/- ##
==========================================
- Coverage 94.11% 92.80% -1.32%
==========================================
Files 26 29 +3
Lines 493 542 +49
==========================================
+ Hits 464 503 +39
- Misses 29 39 +10 ☔ View full report in Codecov by Sentry. |
| "fix": "eslint . --fix", | ||
| "posttest": "eslint . && npm run format:check", | ||
| "eslint": "eslint .", | ||
| "eslint:fix": "npm run eslint -- --fix", |
There was a problem hiding this comment.
Nice. Thanks for splitting this out.
What do you think of lint instead of eslint?
I usually use the name of what it's for, rather than the name of the tool - that way you don't need to remember whether the project has different tools. What do you think?
There was a problem hiding this comment.
I've made this change on master, assuming it wouldn't be terribly contentious
There was a problem hiding this comment.
It's fine for me. There are some cases where there is more than one linter (eg Stylelint + ESLint). In that scenario, a "lint" script usually calls all the other scripts.
In this case, your suggestion makes sense given that ESLint is the only linter in this project (omitting prettier).
|
I really appreciate this one! Upgrading eslint to 9 has been a pain on my other projects, so this had been on my list of "should do, but it'll be annoying". |
Update ESLint before migration to ESM.
PS: Wasn't sure what to do with error on index.js, so I omitted it