Subscription prime #93
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekbrown
reviewed
Jun 21, 2022
| end | ||
|
|
||
| defp send_msg(msg, socket) do | ||
| encoded_msg = socket.serializer.fastlane!(msg) |
There was a problem hiding this comment.
do we care to try/catch this and return a normalized error?
There was a problem hiding this comment.
I don't, but maybe there's a good reason to do it here?
bernardd
force-pushed
the
subscription-prime
branch
from
f22e7f6
to
8c74f51
Compare
bernardd
force-pushed
the
subscription-prime
branch
from
8c74f51
to
d506f01
Compare
bernardd
force-pushed
the
subscription-prime
branch
from
17d069f
to
fb6d5b7
Compare
bernardd
force-pushed
the
subscription-prime
branch
from
fb6d5b7
to
17d069f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the companion PR for absinthe-graphql/absinthe#1168
Like that one, this is still a WIP requiring documentation (and correction of dependencies once the other one is merged).
The main changes here are: a) handling of continuations (the
{:more, ...}return values) and subscription ordinal-based filtering to avoid sending out-of-date updates.