I have removed the instances of abrt-hook-cpp. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgrabovsky
suggested changes
Jan 20, 2021
There was a problem hiding this comment.
Thank you for your pull request. However, it seems you removed a bit too much than what was requested.
Issue #21 pertains to the removal of abrt-hook-ccpp, which was our own version of what is now systemd-coredump. This does not mean that we dropped support for C and C++ completely. I recommend you read the related Fedora wiki page first, to get an idea what changed and which parts of the documentation can be removed.
Specifically, we want to remove mentions of abrt-hook-ccpp and of the abrt-ccpp systemd service. It would also be beneficial to mention that Fedora (and therefore abrt) now use the systemd-coredump service by default.
|
Closing because of no activity for more than a month. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some instances of abrt-addon-cpp which I have left, so should I remove them too? Issue #21