Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release files for 2.4.8 #1167

Merged
merged 7 commits into from
Nov 30, 2020
Merged

Release files for 2.4.8 #1167

merged 7 commits into from
Nov 30, 2020

Conversation

abraunegg
Copy link
Owner

  • Release files for 2.4.8

@abraunegg
Release files for 2.4.8
04e4320 
* Release files for 2.4.8
@abraunegg abraunegg added this to the v2.4.8 milestone Nov 29, 2020
@abraunegg
Copy link
Owner Author

@norbusan
If you are able to review the doc changes here for flow / applicability that would be greatly appreciated. I may make some further changes, so this PR is still a WIP for the moment.

@abraunegg
Update advanced-usage.md
26844ec 
update doc
@abraunegg
update makefile and man page
a392ced 
* update makefile and man page
norbusan
norbusan previously approved these changes Nov 30, 2020
View reviewed changes
Copy link
Collaborator

@norbusan norbusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes and docs look fine, but I am not sure whether the part of sharing between Windows and Linux is actually sufficient to be like that... never tried it.

@abraunegg
update docs
c687ed6 
update docs
@abraunegg
Update CHANGELOG.md
c230782 
* Updated changelog.md
@abraunegg abraunegg changed the title WIP: Release files for 2.4.8 Release files for 2.4.8 Nov 30, 2020
@abraunegg
Copy link
Owner Author

@norbusan

Changes and docs look fine, but I am not sure whether the part of sharing between Windows and Linux is actually sufficient to be like that... never tried it.

The Windows side of things is OK - I have validated that. It assumes a dual-boot, and you are also mounting the data from your Windows partition or storing your Windows OneDrive folder on another drive / folder / partition that is easily accessible / non-encrypted (via BitLocker). The information is enough - so that if you see zero byte files, thats how it can be fixed.

Updated the PR, I think this is good now for final review, will push out the release later on today when I get time.

@abraunegg abraunegg requested a review from norbusan November 30, 2020 01:43
@norbusan
Copy link
Collaborator

The Windows side of things is OK - I have validated that. It assumes a dual-boot, and you are also mounting the data from your Windows partition or storing your Windows OneDrive folder on another drive / folder / partition that is easily accessible / non-encrypted (via BitLocker). The information is enough - so that if you see zero byte files, thats how it can be fixed.

Cool, guess I have to try that myself instead of keeping long exception lists to separate the two onedrives.

@abraunegg abraunegg merged commit 545fdcd into master Nov 30, 2020
@abraunegg abraunegg linked an issue Nov 30, 2020 that may be closed by this pull request
Add a bit to documentation for using the same folder when dual booting #1160
Closed
@abraunegg abraunegg deleted the release-2.4.8 branch November 30, 2020 05:44
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@norbusan norbusan norbusan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.4.8
Development

Successfully merging this pull request may close these issues.

Add a bit to documentation for using the same folder when dual booting
2 participants
@abraunegg @norbusan