implement TailProcessStdoutLog and add go mod #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrander
requested changes
Oct 22, 2021
| @@ -0,0 +1,5 @@ | |||
| module github.com/abrander/go-supervisord | |||
|
|
|||
| go 1.16 | |||
There was a problem hiding this comment.
Do we actually require Go 1.16 for anything..? I'm not that familiar with modules - but can you use this with a Go version older than 1.16?
| @@ -20,8 +20,14 @@ func (c *Client) ReadProcessStderrLog(name string, offset int, length int) (stri | |||
| } | |||
|
|
|||
| // This is not implemented yet. | |||
There was a problem hiding this comment.
I think we should update the comment.
processlogging.go
Outdated
| if err != nil { | ||
| return "", err | ||
| } | ||
| return ret[0].(string), nil |
There was a problem hiding this comment.
I'm unsure as to why you only return the first member of the slice..?
| func (c *Client) TailProcessStdoutLog(name string, offset int, length int) ([]LogSegment, error) { | ||
| return nil, FIXMENotImplementedError | ||
| func (c *Client) TailProcessStdoutLog(name string, offset int, length int) (string, error) { | ||
| ret := make([]interface{}, 0) |
There was a problem hiding this comment.
Why is interface{} needed? You're type asserting to string below..?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.