Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collected latest package-lock.json #3981

Closed

Conversation

VarshaUN
Copy link

@VarshaUN VarshaUN commented Nov 9, 2024

Fixes #3493

Updated to the latest package-lock.json

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass --
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

Signed-off-by: Varsha U N [email protected]

Signed-off-by: Varsha U N <[email protected]>
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VarshaUN I think you've misunderstood the issue:

I don't see any code changes in your PR, just test file updates.
We don't want to update old test files at all unless there are good reasons for this.
We want to:

  1. look at all the new features in these lockfile spec, and for each one of them for example see the differences between https://docs.npmjs.com/cli/v10/configuring-npm/package-lock-json and https://docs.npmjs.com/cli/v6/configuring-npm/package-lock-json (you can do a diff for the texts, and do this for other versions of the documentation)
  2. add test examples for these by using the github search, add tests like the ones at https://github.com/aboutcode-org/scancode-toolkit/blob/develop/tests/packagedcode/test_npm.py#L253
  3. update the package-lock.json parser at https://github.com/aboutcode-org/scancode-toolkit/blob/develop/src/packagedcode/npm.py#L793 to parse and store the additional info

@VarshaUN VarshaUN closed this Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure we can collect the latest package-lock.json including file indirections for versions
2 participants