Fix 180: Add environment variables to Click CLI options #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calizarr
force-pushed
the
fix-180-env-vars
branch
from
4b0129f
to
77d09da
Compare
|
I believe I've just rebased and added my signature. |
|
@calizarr not all the commits have the sign-off, neither the PR description have it |
|
Alright, I'll try again. Not entirely sure how to add it to the PR description though |
|
Something like this
in the end of PR description |
calizarr
force-pushed
the
fix-180-env-vars
branch
6 times, most recently
from
fe1df6c
to
ce07ad6
Compare
Signed-off-by: Cesar Lizarraga <[email protected]>
calizarr
force-pushed
the
fix-180-env-vars
branch
from
ce07ad6
to
8b25fc8
Compare
Signed-off-by: Cesar Lizarraga <[email protected]>
They should be able to use the same ones as the flag. Signed-off-by: Cesar Lizarraga <[email protected]>
Signed-off-by: Cesar Lizarraga <[email protected]>
calizarr
force-pushed
the
fix-180-env-vars
branch
from
8b25fc8
to
c34aaa9
Compare
|
All commits should be signed off now. @pombredanne @TG1999 |
Adjust for too long filenames where there's basic auth aka: https://username:password@URL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add environment variables as extra options for the index-url flag. Click will split on whitespace for multiple values by default.
Added a possibly unnecessary test to make sure that flags override environment variables.
Signed-off-by: Cesar Lizarraga [email protected]