Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rings-v1.0.1 rings test deployment #1

Merged
merged 8 commits into from
Nov 5, 2024

Conversation

benjaminbollen
Copy link
Member

@benjaminbollen benjaminbollen commented Oct 31, 2024

  • apologies for the deployment artefacts that are also just here. please ignore as best as possible
  • simplified registerHuman to basically always work: self-register with inviter=0 at any time; or emulate invitation behavior with an inviter
  • welcome bonus always given 200 RINGS;
  • when inviter invites, must pay 0.1 RINGS invitation cost
  • symbol and name Rings, RINGS

@benjaminbollen benjaminbollen force-pushed the v1.0.1-rings-test-deployment branch from 31fb294 to 94752ca Compare October 31, 2024 18:38
@benjaminbollen benjaminbollen marked this pull request as ready for review October 31, 2024 18:41
@benjaminbollen
Copy link
Member Author

deployed and verified (on gnosisscan only hub.sol so far)

deployment tag https://github.com/aboutcircles/rings-test-contracts-v2/releases/tag/rings-1.0.1-tests

task to verify all (circles beta, possibly older rings and this rings): https://github.com/orgs/aboutcircles/projects/19/views/1?pane=issue&itemId=85381752&issue=aboutcircles%7Ccircles-contracts-v2%7C81

@roleengineer roleengineer self-requested a review November 1, 2024 09:48
Copy link

@roleengineer roleengineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and efficient solution for Rings. LGTM!

src/hub/Hub.sol Show resolved Hide resolved
@benjaminbollen benjaminbollen merged commit e979412 into develop Nov 5, 2024
@benjaminbollen benjaminbollen deleted the v1.0.1-rings-test-deployment branch November 13, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants