rc-v1.0.1-stable proposed bytecode optimization to merge into stable branch #91
Conversation
|
@roleengineer I moved this to a new epic #93 because I think that if we propose improvements, we should first setup measurements and CI regression checks, no? |
benjaminbollen
changed the base branch from
rc-v1.0.1-stable
to
candidate/stable
|
changed the target branch to |
|
if #94 is correct and merged then hopefully here we will have the CI activated @roleengineer |
| @@ -114,10 +114,7 @@ abstract contract ERC1155 is DiscountedBalances, Context, ERC165, IERC1155, IERC | |||
| * @dev See {IERC1155-safeTransferFrom}. | |||
| */ | |||
| function safeTransferFrom(address _from, address _to, uint256 _id, uint256 _value, bytes memory _data) public { | |||
| address sender = _msgSender(); | |||
There was a problem hiding this comment.
as mentioned before, I tried to not update this forked contract from open zepellin unless where functionally needed. that said, sure this seems like a fair readability improvement.
It would be good to have measurements in place in CI so we can see whether this increases or reduces different metrics. I don't want to walk blind for optimisations
| @@ -91,10 +91,7 @@ contract DiscountedBalances is Demurrage { | |||
| // revert CirclesDemurrageAmountExceedsMaxUint192(_account, _id, _balance, 0); | |||
| revert CirclesErrorAddressUintArgs(_account, _id, 0x81); | |||
| } | |||
| DiscountedBalance memory discountedBalance = discountedBalances[_id][_account]; | |||
There was a problem hiding this comment.
this is possibly an improvement, but as mentioned some of these changes were done on recommendation of reviewers. so my general comment holds, i would like to start measuring explicitly to see what is an optimisation in numbers
(workflow): update active CI branches
|
(trying to trigger CI fyi) |
(CI): add bytecode size and gas difference reporting
pull from beta into rc-v1.0.1-bytecode-optimization
Made a few slight adjustments to optimize bytecode size by consolidating some repeating code patterns. This should help streamline the overall efficiency without impacting functionality.