change make method

abordage · Jun 3, 2022 · ea08818 · ea08818
1 parent 912448b
commit ea08818
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 3 deletions.
diff --git a/src/OpenGraphImages.php b/src/OpenGraphImages.php
@@ -242,11 +242,26 @@ public function __construct(array $config = [])
         }
     }
 
-    public function make(string $text, int $width = 1200, int $height = 630): OpenGraphImages
+    public function make(string $text, string $preset = 'opengraph'): OpenGraphImages
     {
         // https://developers.facebook.com/docs/sharing/webmasters/images/
-        $this->imageWidth = $width;
-        $this->imageHeight = $height;
+        // https://developer.twitter.com/en/docs/twitter-for-websites/cards/overview/summary-card-with-large-image
+        // https://dev.vk.com/api/posts
+
+        $this->imageWidth = 1200;
+        switch (strtolower($preset)) {
+            case 'opengraph':
+            case 'facebook':
+            default:
+                $this->imageHeight = 630;
+                break;
+            case 'twitter':
+                $this->imageHeight = 600;
+                break;
+            case 'vk':
+                $this->imageHeight = 536;
+                break;
+        }
 
         $this->createImage($text);
 

diff --git a/tests/OpenGraphImagesTest.php b/tests/OpenGraphImagesTest.php
@@ -30,6 +30,13 @@ public function testMake(string $text): void
         $result = $this->openGraphImages->make($text);
         $this->assertInstanceOf(OpenGraphImages::class, $result);
         $this->assertEquals('image/png', $this->getMimeTypeFromString($result->get()));
+
+        $presets = ['opengraph', 'facebook', 'twitter', 'vk'];
+        foreach ($presets as $preset) {
+            $result = $this->openGraphImages->make($text, $preset);
+            $this->assertInstanceOf(OpenGraphImages::class, $result);
+            $this->assertEquals('image/png', $this->getMimeTypeFromString($result->get()));
+        }
     }
 
     /**