Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECO-5144] Implement CHA-PR3h etc #163

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[ECO-5144] Implement CHA-PR3h etc #163

wants to merge 3 commits into from
+170 −116

Commits on Dec 2, 2024

  1. Fix typo in spec point IDs 

    Mistake in 9c97883.
    @lawrence-forooghian
    lawrence-forooghian committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    e05f108 View commit details
    Browse the repository at this point in the history

  2. Decouple error codes from status codes 

    This is in preparation for implementing CHA-PR3h, in which a given
numerical error code no longer necessarily implies a specific status
code (specifically, RoomInInvalidState may now have a 400 or 500 status
code depending on the context in which it is thrown).

The internal API introduced here is a bit convoluted and verbose, but
I’ve done it this way for two reasons:

1. It reflects the way the spec is written; most of the time a numeric
   code has a status code written alongside it

2. For the numerical error codes that _do_ always imply a certain status
   code, I want to be able to get that status code still, so that the
   existing Messages code that throws an error with the
   messagesAttachmentFailed code, as well as the isChatError(…) test
   helper, continue to work as they currently do.
    @lawrence-forooghian
    lawrence-forooghian committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    f1cd8d6 View commit details
    Browse the repository at this point in the history

  3. Implement CHA-PR3h and similar 

    Resolves #151.
    @lawrence-forooghian
    lawrence-forooghian committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    cf769a1 View commit details
    Browse the repository at this point in the history