Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECO-4986] Implement the RETRY room lifecycle operation #110

Merged
merged 6 commits into from
Nov 19, 2024
Merged

[ECO-4986] Implement the RETRY room lifecycle operation #110

merged 6 commits into from
Nov 19, 2024
+618 −47

Commits on Nov 19, 2024

  1. Consistently use mock behaviour shorthand 

    For whatever reason, I forgot to do this in some places.
    @lawrence-forooghian
    lawrence-forooghian committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    63d01a0 View commit details
    Browse the repository at this point in the history

  2. Enhance contributor mock’s state change handling 

    Add an option for it to emit a state change when you subscribe to its
state. Will use in an upcoming commit.
    @lawrence-forooghian
    lawrence-forooghian committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    db160bf View commit details
    Browse the repository at this point in the history

  3. Split attachment & detachment cycles into methods 

    We’ll use these when we implement the RETRY operation in #51.

References to CHA-RL5* points are based on spec at 8ff947d.
    @lawrence-forooghian
    lawrence-forooghian committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    05f2a03 View commit details
    Browse the repository at this point in the history

  4. Link the SUSPENDED status to a RETRY operation 

    This is so that when we implement our upcoming RETRY operation, the
manager’s `hasOperationInProgress` will return `true` if a RETRY
operation is in progress.
    @lawrence-forooghian
    lawrence-forooghian committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    c0ddfd0 View commit details
    Browse the repository at this point in the history

  5. Fill in previously-unspecified wait durations 

    This are now specified. Taken from spec version 8ff947d.
    @lawrence-forooghian
    lawrence-forooghian committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    a04d20c View commit details
    Browse the repository at this point in the history

  6. Implement RETRY room lifecycle operation 

    Based on spec at bfcfa7e.

The internal triggering of the RETRY operation (as specified by
CHA-RL1h3 and CHA-RL4b9) will come in #50.

Resolves #51.
    @lawrence-forooghian
    lawrence-forooghian committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    c8c1574 View commit details
    Browse the repository at this point in the history