Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECO-5009][CHA-RL1] RoomLifecycle ATTACH tests #37

Closed
wants to merge 21 commits into from
Closed

[ECO-5009][CHA-RL1] RoomLifecycle ATTACH tests #37

wants to merge 21 commits into from

Commits on Oct 25, 2024

  1. Added basic unit tests for room lifecyclemanager attach

    @sacOO7
    sacOO7 committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    d990bd6 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Merge branch 'feature/roomlifecycle-attach-with-retry' into tests/roo… 

    …mlifecycle-attach
    @sacOO7
    sacOO7 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    0a6a45e View commit details
    Browse the repository at this point in the history

  2. Fixed RoomLifecycleManagerTest, added sequentialRoomScope property to… 

    … the test
    @sacOO7
    sacOO7 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    983ec92 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Marked atomicCoroutineScope as internal to access from tests, added e… 

    …mpty

impl for detach and release method, Added test for spec CHA-RL1d
    @sacOO7
    sacOO7 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    18cc65d View commit details
    Browse the repository at this point in the history

  2. Refactored RoomLifecycleManagerTest, added more assertions for CHA-RL1d

    @sacOO7
    sacOO7 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    30ad922 View commit details
    Browse the repository at this point in the history

  3. Marked atomicCoroutineScope as private, accessed via reflection+exten… 

    …sion feature
    @sacOO7
    sacOO7 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    0a9d391 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Bumped up io.mocck test dependency to latest version

    @sacOO7
    sacOO7 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    52005c0 View commit details
    Browse the repository at this point in the history

  2. Added channel attach room lifecycle spec CHA-RL1f, CHA-RL1g, updated 

    testhelpers for the same
    @sacOO7
    sacOO7 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    b6f4dbd View commit details
    Browse the repository at this point in the history

  3. Added mising unit test case blocks for channel attach

    @sacOO7
    sacOO7 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    1d92116 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Added test for spec CHA-RL1h1 channel attach, improved exception hand… 

    …ling accordingly
    @sacOO7
    sacOO7 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    29a9782 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature/roomlifecycle-attach-with-retry' into tests/roo… 

    …mlifecycle-attach

# Conflicts:
#	chat-android/src/main/java/com/ably/chat/AtomicCoroutineScope.kt
    @sacOO7
    sacOO7 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    0f400b1 View commit details
    Browse the repository at this point in the history

  3. Refactored roomLifeCycle ATTACH tests with respective spec

    @sacOO7
    sacOO7 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    54a01c3 View commit details
    Browse the repository at this point in the history

  4. Added channel attach retry test as per spec CHA-RL1h3

    @sacOO7
    sacOO7 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    2fee93d View commit details
    Browse the repository at this point in the history

  5. Added channel attach unit test for contributor failure, get all remai… 

    …ning

channels into failed state
    @sacOO7
    sacOO7 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    e6b46ff View commit details
    Browse the repository at this point in the history

  6. Added channel attach failure test, retry channel detach remaining cha… 

    …nnels

on attach failure
    @sacOO7
    sacOO7 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    f097e96 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Annotated RoomLifeCycleManager code with right spec tags, refactored … 

    …attach tests
    @sacOO7
    sacOO7 committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    e73b9ba View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature/roomlifecycle-attach-with-retry' into tests/roo… 

    …mlifecycle-attach

# Conflicts:
#	chat-android/src/main/java/com/ably/chat/RoomLifecycleManager.kt
#	chat-android/src/main/java/com/ably/chat/RoomReactions.kt
#	chat-android/src/main/java/com/ably/chat/Utils.kt
    @sacOO7
    sacOO7 committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    a9fffc2 View commit details
    Browse the repository at this point in the history

  3. Fixed linting issues for roomlifecycle attach tests

    @sacOO7
    sacOO7 committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    774cc3b View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. Merge branch 'feature/roomlifecycle-attach-with-retry' into tests/roo… 

    …mlifecycle-attach
    @sacOO7
    sacOO7 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    4fc33c7 View commit details
    Browse the repository at this point in the history

  2. Added detach delay to fix test flakiness for channel detach

    @sacOO7
    sacOO7 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    097e82c View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Refactored room attach tests with proper naming convention, 

    replaced magical error codes with reference to ErrorCode enum constant
    @sacOO7
    sacOO7 committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    f4883bc View commit details
    Browse the repository at this point in the history