This repository has been archived by the owner on Oct 30, 2023. It is now read-only.
feat: add useChannelStateListener and useConnectionStateListener hooks
#65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenpearson
force-pushed
the
add-useConnectionState-and-useChannelState
branch
2 times, most recently
from
f3554f2
to
595ce39
Compare
ttypic
reviewed
Aug 9, 2023
owenpearson
force-pushed
the
add-useConnectionState-and-useChannelState
branch
2 times, most recently
from
8f2ba2a
to
a84eb93
Compare
owenpearson
force-pushed
the
add-useConnectionState-and-useChannelState
branch
from
a84eb93
to
0e3d0af
Compare
this functionality is covered by the listener hooks and it's straightforward enough to get the same behaviour by just updating a `useState` inside the listener function so i'm removing these for now just for simplicity.
gives the user full control over whether their component re-renders
owenpearson
force-pushed
the
add-useConnectionState-and-useChannelState
branch
from
0e3d0af
to
46f98d6
Compare
ttypic
approved these changes
Aug 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #52
Resolves #54, #59
Jira links:
I've opted to remove the
useChannelStateanduseConnectionStatehooks for now since the functionality is already covered with the listener variants and it's relatively simple to make a component re-render when the state changes usinguseState. If there's demand for it we can always add the non-listener variants back in future.