Added Region for lower latency #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishekkrthakur
requested changes
Feb 3, 2021
| @@ -60,6 +62,7 @@ def _install_extensions(): | |||
| subprocess.run(["code-server", "--install-extension", f"{ext}"]) | |||
|
|
|||
| def _start_server(self): | |||
| conf.get_default().region = self.region | |||
There was a problem hiding this comment.
please pass region in options here: url = ngrok.connect(addr=self.port, options={"bind_tls": True})
There was a problem hiding this comment.
I've tried it out but it does not work by doing that. That's why I have used this method as mentioned in pyngrok docs (https://pyngrok.readthedocs.io/en/latest/#setting-the-region).
There was a problem hiding this comment.
Hello Sir, Could you please review this? I've tried the change you mention but it doesn't seem to work.
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| import nest_asyncio | |||
| import uvicorn | |||
| from pyngrok import ngrok | |||
| from pyngrok import ngrok, conf | |||
misalraj
reviewed
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a region argument to ColabCode class so users can choose their closest location and have lower latency. And added description and example of that in README.
The available regions are:
us - United States (default)
eu - Europe
ap - Asia/Pacific
au - Australia
sa - South America
jp - Japan
in - India