chore: rewrite rot13 title and description #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhimanyu003
reviewed
Jun 4, 2024
processors/rot13.go
Outdated
| } | ||
|
|
||
| func (p ROT13) Alias() []string { | ||
| return []string{"rot13-encode", "rot13-decode", "rot13-enc", "rot13-dec"} |
There was a problem hiding this comment.
I'm a little bit confused about the alias now, should we keep rot13-decode and rot13-dec or not in the list? I think I might approve but I need to think little bit more on this
There was a problem hiding this comment.
I added them because some people may think they could decode this way. I didn't want to remove the rot13-enc* aliases, I thought it would be good to add them for people who don't know how it works.
I would say it's up to you. I can remove them, remove also the rot13-enc*. You tell me
There was a problem hiding this comment.
I would like to keep rot13-encode and rot-enc and remove "rot13-decode" "rot13-dec".
|
Thanks so much for your contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46