Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves parsing speed #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joreg
Copy link
Contributor

@joreg joreg commented Oct 11, 2024

Especially with the faster A2 sensor scanning is very slow and getting slower over time. Turned out the serialPort incoming buffer was increasing steadily because bytes were not read fast enough.

This PR does the following two things:

  • Instead of reading bytes one-by-one from the serialPort, it always reads the whole available buffer in one operation
  • Reusing a global responseBuffer instead of allocating a new one for each response

This most likely will solve #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant