-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect / Disconnect workaround #32
Conversation
Relates to #31 |
Up to this point the patch is minor and largely deals with handling edge cases (i.e socket errors) |
Please rebase and update PR title if ready to be merged |
Today this PR can be considered complete as far as Noble compatibility (I put it through it's paces) I don't have any bleno knowledge, if someone wants to test it for bleno feel free to submit results |
tests feedback welcome |
please preserve other files and open other PR and explain why they should be removed |
may you squash changes ? |
@rzr I didnt realize I didnt pr as as a feature branch (my bad). This next set of commits is experimental (tried to fix npm 7 and some issues with late version npm 6). I'll squash / remove before this is likely to merge. |
it's not a problem, this way you can check CI results, a way to make it it clear it's a WIP is to set PR to draft to make sure it won't be merged until ready. |
I think change set is good to be rebased , squashed and then merged ? |
Superceeded by #33 |
Not ready to merge
Also includes a build command
npm run build
for QoL during development