Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect / Disconnect workaround #32

Closed
wants to merge 13 commits into from

Conversation

splitice
Copy link

@splitice splitice commented Nov 3, 2021

Not ready to merge

Also includes a build command npm run build for QoL during development

@splitice
Copy link
Author

splitice commented Nov 3, 2021

Relates to #31

@splitice
Copy link
Author

splitice commented Nov 3, 2021

Up to this point the patch is minor and largely deals with handling edge cases (i.e socket errors)

@rzr
Copy link

rzr commented Nov 3, 2021

Please rebase and update PR title if ready to be merged

@splitice
Copy link
Author

splitice commented Nov 8, 2021

Today this PR can be considered complete as far as Noble compatibility (I put it through it's paces)

I don't have any bleno knowledge, if someone wants to test it for bleno feel free to submit results

@splitice splitice changed the title WIP: Connect / Disconnect workaround Connect / Disconnect workaround Nov 8, 2021
@rzr
Copy link

rzr commented Nov 8, 2021

tests feedback welcome

@rzr
Copy link

rzr commented Nov 16, 2021

please preserve other files and open other PR and explain why they should be removed

@rzr
Copy link

rzr commented Nov 18, 2021

may you squash changes ?

@splitice
Copy link
Author

splitice commented Nov 19, 2021

@rzr I didnt realize I didnt pr as as a feature branch (my bad). This next set of commits is experimental (tried to fix npm 7 and some issues with late version npm 6). I'll squash / remove before this is likely to merge.

@rzr
Copy link

rzr commented Nov 19, 2021

it's not a problem, this way you can check CI results, a way to make it it clear it's a WIP is to set PR to draft to make sure it won't be merged until ready.

@rzr
Copy link

rzr commented Nov 23, 2021

I think change set is good to be rebased , squashed and then merged ?

@splitice
Copy link
Author

splitice commented Nov 23, 2021

@rzr I'll fix this pr so that it ends at 94e1a26 for you this week.

@splitice
Copy link
Author

splitice commented Dec 1, 2021

Superceeded by #33

@splitice splitice closed this Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants