Forwarded disconnect reason to higher level #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
does this close any existing issue ? |
|
Not that I know of. But we use this since year in our system. |
|
may be related: abandonware/node-bluetooth-hci-socket#31 |
|
@rzr this doesn't fix anything, it only passes additional data up to higher layers (which will ignore it without pr there to do something with it) |
|
Any clue with osx error , we plan to release a new version soon |
|
The OSX error looks like an issue cloning from github. I don't see anything which would be related to this PR at all. In fact, it looks like it didn't even get to the point of the tests :-) |
|
ok please rebase and push (updated commit message) to relaunch build test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.