compaso: more flexible search for halo cleaning info directory #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a few different directory layouts for the cleaned halo info relative to the halo catalog directory. We might wish to standardize this at some point, but for the moment it seems best to just add support at the Python wrapper level. This PR ensures support for the following 4 layouts:
It probably supports more, since search is flexible about walking up the directory tree until it encounters
cleaning, and about whether acleaned_halo_infodir is required. But these 4 are the canonical layouts that we might see in practice and that are now tested.