Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the halo light cone catalogs in the Backlight project, we're doing halo finding on the time slices, then interpolating them onto the light cone with merger trees. Many time slice halos won't appear in the light cone, so there's no point in saving them. When we create the "squashed" catalogs that remove unused halos, we don't want to unpack all the columns, we want them to stay in their original format (e.g. we don't want to unpack rvint subsamples, because the floats won't compress as well). But we still want to load things through the
CompaSOHaloCatalog
interface, because it does all sorts of non-trivial merging of the uncleaned and cleaned halo info and subsamples, as well as row-based filtering, which we're going to use to get rid of unused halos.This PR adds a
passthrough
bool argument to the CHC constructor to load halo info and subsamples without unpacking them. This effectively provides a way to get the raw data through CHC. Most users won't need this unless they're writing a pipeline where they want to defer the unpacking of the data to a later stage (often at the end-user stage, as CHC usually does).