-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add metamask sdk #2226
base: main
Are you sure you want to change the base?
feat: add metamask sdk #2226
Conversation
|
❌ CI run has failed! |
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
544.7 KB (🟡 +1.75 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Eight Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
Page | Size (compressed) | First Load |
---|---|---|
/ |
65.95 KB (🔴 +18.06 KB) |
610.65 KB |
/bridge |
36.21 KB (🟢 -25 B) |
580.91 KB |
/faucet |
15.1 KB (-1 B) |
559.8 KB |
/governance/v3/proposal |
124.15 KB (-5 B) |
668.84 KB |
/markets |
27.45 KB (🟢 -99 B) |
572.15 KB |
/reserve-overview |
19.76 KB (🟡 +86 B) |
564.46 KB |
/staking |
22.11 KB (🟢 -733 B) |
566.8 KB |
/v3-migration |
29.98 KB (🟡 +21 B) |
574.68 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link
is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
Thanks for the PR @EdouardBougon What are the advantages to using this sdk vs. the injected connector that we're currently using. |
549a429
to
0108e92
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@EdouardBougon is attempting to deploy a commit to the Avara Team on Vercel. A member of the Team first needs to authorize it. |
MetaMask SDK integration
This PR adds the connection to MetaMask using the MetaMask SDK.
We have developed a specific Web3-React connector.
The SDK must be used for both connecting via the extension and on mobile.