feat: sdai wrapping #1869
feat: sdai wrapping #1869
Conversation
* feat: consolidating shared approval logic * feat: useApprovalTx hook * fix: refetch on mount always to fetch on modal open * fix: apply refetch on mount * fix: check for amount before requiring approval * fix: removed duplicate file * fix: cleanup * fix: clean up loading states, remove uneeded useEffects * fix: don't automatically refetch approval amounts * fix: don't automatically refetch approved amounts
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
523.08 KB (🟡 +404 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Six Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/ |
94.65 KB (🟡 +1.87 KB) |
617.73 KB |
/faucet |
43.49 KB (-1 B) |
566.57 KB |
/governance |
101.37 KB (-1 B) |
624.46 KB |
/governance/v3/proposal |
141.14 KB (-1 B) |
664.22 KB |
/reserve-overview |
40.19 KB (-1 B) |
563.27 KB |
/staking |
36.82 KB (-1 B) |
559.91 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
523.08 KB (🟡 +404 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Six Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/ |
94.65 KB (🟡 +1.87 KB) |
617.73 KB |
/faucet |
43.49 KB (-1 B) |
566.57 KB |
/governance |
101.37 KB (-1 B) |
624.46 KB |
/governance/v3/proposal |
141.14 KB (-1 B) |
664.22 KB |
/reserve-overview |
40.19 KB (-1 B) |
563.27 KB |
/staking |
36.82 KB (-1 B) |
559.91 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
|
|
Link T-13962 |
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
523.08 KB (🟡 +404 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Six Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/ |
94.63 KB (🟡 +1.85 KB) |
617.71 KB |
/faucet |
43.49 KB (-1 B) |
566.57 KB |
/governance |
101.37 KB (-1 B) |
624.46 KB |
/governance/v3/proposal |
141.14 KB (-1 B) |
664.22 KB |
/reserve-overview |
40.19 KB (-1 B) |
563.27 KB |
/staking |
36.82 KB (-1 B) |
559.91 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
523.08 KB (🟡 +403 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Six Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/ |
94.63 KB (🟡 +1.85 KB) |
617.71 KB |
/faucet |
43.49 KB (-1 B) |
566.57 KB |
/governance |
101.37 KB (-1 B) |
624.46 KB |
/governance/v3/proposal |
141.14 KB (-1 B) |
664.22 KB |
/reserve-overview |
40.19 KB (-1 B) |
563.27 KB |
/staking |
36.82 KB (-1 B) |
559.9 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
524.83 KB (🟡 +2.14 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Nine Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/ |
93.3 KB (🟡 +531 B) |
618.13 KB |
/404 |
16.27 KB (-1 B) |
541.11 KB |
/faucet |
43.49 KB (-1 B) |
568.32 KB |
/governance |
101.37 KB (-1 B) |
626.21 KB |
/governance/ipfs-preview |
111.35 KB (🟡 +1 B) |
636.18 KB |
/history |
50.89 KB (🟢 -739 B) |
575.73 KB |
/markets |
38.8 KB (🟡 +1 B) |
563.63 KB |
/reserve-overview |
39.5 KB (🟢 -704 B) |
564.34 KB |
/v3-migration |
48.64 KB (🟢 -697 B) |
573.47 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
|
grothem
dismissed stale reviews from foodaka and JoaquinBattilana
via
4598b7d
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
528.99 KB (🟡 +6.3 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Twelve Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/ |
88.69 KB (🟢 -4.09 KB) |
617.68 KB |
/404 |
16.28 KB (🟡 +1 B) |
545.27 KB |
/500 |
16.69 KB (🟡 +1 B) |
545.69 KB |
/faucet |
38.77 KB (🟢 -4.72 KB) |
567.76 KB |
/governance |
97.89 KB (🟢 -3.48 KB) |
626.88 KB |
/governance/ipfs-preview |
111.35 KB (🟡 +1 B) |
640.34 KB |
/governance/v3/proposal |
137.66 KB (🟢 -3.48 KB) |
666.65 KB |
/history |
47.41 KB (🟢 -4.2 KB) |
576.41 KB |
/markets |
38.8 KB (🟡 +2 B) |
567.79 KB |
/reserve-overview |
34.75 KB (🟢 -5.44 KB) |
563.74 KB |
/staking |
33.36 KB (🟢 -3.46 KB) |
562.35 KB |
/v3-migration |
48.63 KB (🟢 -703 B) |
577.63 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
General Changes
Developer Notes
TODO:
Author Checklist
Please ensure you, the author, have gone through this checklist to ensure there is an efficient workflow for the reviewers.
mainIf the PR is ready for review:
Openstate and not inDraftmodeReady for Dev Reviewlabel has been addedReviewer Checklist
Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.
.env.examplefile as well as the pertinant.github/actions/*files