Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sdai wrapping #1858

Closed
wants to merge 310 commits into from
Closed

feat: sdai wrapping #1858

wants to merge 310 commits into from

Conversation

grothem
Copy link
Collaborator

@grothem grothem commented Nov 22, 2023

General Changes

  • Adds in ability for users to supply DAI as sDAI and withdraw sDAI as DAI

Developer Notes

TODO:

Add any notes here that may be helpful for reviewers.


Author Checklist

Please ensure you, the author, have gone through this checklist to ensure there is an efficient workflow for the reviewers.

  • The base branch is set to main
  • The title is using Conventional Commit formatting
  • The Github issue has been linked to the PR in the Development section
  • The General Changes section has been filled out
  • Developer Notes have been added (optional)

If the PR is ready for review:

  • The PR is in Open state and not in Draft mode
  • The Ready for Dev Review label has been added

Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • End-to-end tests are passing without any errors
  • Code style generally follows existing patterns
  • Code changes do not significantly increase the application bundle size
  • If there are new 3rd-party packages, they do not introduce potential security threats
  • If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • There are no CI changes, or they have been approved by the DevOps and Engineering team(s)
  • Code changes have been quality checked in the ephemeral URL
  • QA verification has been completed
  • There are two or more approvals from the core team
  • Squash and merge has been checked

Copy link

height bot commented Nov 22, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@MareskoY
Copy link
Contributor

@grothem

BUG1
there is an issue with eth frok, not possible to supply DAI as sDAI

Screenshot 2023-11-23 at 11 07 27

BUG2
there is no option to withdraw DAI as sDAI (mainnet)
Screenshot 2023-11-23 at 11 15 59

BUG3
error on supply DAI as sDAI

_context.t0 is not a constructor
Screenshot 2023-11-23 at 11 17 27

Base automatically changed from feat/repay-bundle to main November 27, 2023 14:35
Cache bot and others added 26 commits November 27, 2023 13:22
* chore: show usd values on assets for supply

* fix: max slippage for switch widget

* fix: max slippage for switch widget

* feat: show dollar value on borrow

---------

Co-authored-by: Nikita Boakrev <[email protected]>
@grothem grothem marked this pull request as ready for review November 27, 2023 19:28
@grothem
Copy link
Collaborator Author

grothem commented Nov 27, 2023

History got all messed up from a bad merge, closing this one in favor of #1869

@grothem grothem closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants