Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Repay bundle #1773

Merged
merged 32 commits into from
Nov 27, 2023
Merged

Feat: Repay bundle #1773

merged 32 commits into from
Nov 27, 2023

Conversation

JoaquinBattilana
Copy link
Member

General Changes

  • Fixes XYZ bug
  • Adds XYZ feature

Developer Notes

Add any notes here that may be helpful for reviewers.


Author Checklist

Please ensure you, the author, have gone through this checklist to ensure there is an efficient workflow for the reviewers.

  • The base branch is set to main
  • The title is using Conventional Commit formatting
  • The Github issue has been linked to the PR in the Development section
  • The General Changes section has been filled out
  • Developer Notes have been added (optional)

If the PR is ready for review:

  • The PR is in Open state and not in Draft mode
  • The Ready for Dev Review label has been added

Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • End-to-end tests are passing without any errors
  • Code style generally follows existing patterns
  • Code changes do not significantly increase the application bundle size
  • If there are new 3rd-party packages, they do not introduce potential security threats
  • If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • There are no CI changes, or they have been approved by the DevOps and Engineering team(s)
  • Code changes have been quality checked in the ephemeral URL
  • QA verification has been completed
  • There are two or more approvals from the core team
  • Squash and merge has been checked

@height
Copy link

height bot commented Sep 4, 2023

This pull request has been linked to 1 task:

💡Tip: Add "Close T-7615" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 574.31 KB (🟡 +842 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

* feat: consolidating shared approval logic

* feat: useApprovalTx hook

* fix: refetch on mount always to fetch on modal open

* fix: apply refetch on mount

* fix: check for amount before requiring approval

* fix: removed duplicate file

* fix: cleanup

* fix: clean up loading states, remove uneeded useEffects

* fix: don't automatically refetch approval amounts

* fix: don't automatically refetch approved amounts
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 577.72 KB (🟡 +4.23 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 43.62 KB (-2 B) 621.35 KB
/404 6.6 KB (🟡 +1 B) 584.32 KB
/500 7.04 KB (🟢 -1 B) 584.76 KB
/governance 79.73 KB (🟢 -12 B) 657.46 KB
/history 31.7 KB (🟡 +1 B) 609.43 KB
/markets 18.49 KB (🟢 -2 B) 596.22 KB
/reserve-overview 15.4 KB (🟢 -3 B) 593.12 KB
/staking 21.67 KB (🟢 -9 B) 599.4 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 577.73 KB (🟡 +4.24 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 43.62 KB (-2 B) 621.35 KB
/404 6.6 KB (🟡 +1 B) 584.33 KB
/500 7.04 KB (🟢 -1 B) 584.77 KB
/governance 79.73 KB (🟢 -12 B) 657.47 KB
/history 31.7 KB (🟡 +1 B) 609.44 KB
/markets 18.49 KB (🟢 -2 B) 596.23 KB
/reserve-overview 15.4 KB (🟢 -3 B) 593.13 KB
/staking 21.67 KB (🟢 -9 B) 599.41 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 577.82 KB (🟡 +4.32 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 43.62 KB (-2 B) 621.44 KB
/404 6.6 KB (🟡 +1 B) 584.42 KB
/500 7.04 KB (🟢 -1 B) 584.86 KB
/governance 79.73 KB (🟢 -12 B) 657.55 KB
/history 31.7 KB (🟡 +1 B) 609.52 KB
/markets 18.49 KB (🟢 -2 B) 596.31 KB
/reserve-overview 15.4 KB (🟢 -3 B) 593.22 KB
/staking 21.67 KB (🟢 -9 B) 599.49 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 574.77 KB (🟡 +1.28 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/governance 79.73 KB (🟢 -13 B) 654.5 KB
/staking 21.67 KB (🟢 -10 B) 596.44 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

@github-actions
Copy link

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 574.77 KB (🟡 +1.28 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/governance 79.73 KB (🟢 -13 B) 654.51 KB
/staking 21.67 KB (🟢 -10 B) 596.45 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@github-actions
Copy link

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 575.13 KB (🟡 +1.58 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 43.7 KB (🟡 +1 B) 618.84 KB
/500 7.04 KB (🟢 -1 B) 582.17 KB
/governance 79.73 KB (🟢 -17 B) 654.86 KB
/history 31.7 KB (🟡 +1 B) 606.84 KB
/markets 18.71 KB (-1 B) 593.84 KB
/reserve-overview 15.4 KB (🟡 +1 B) 590.54 KB
/staking 21.68 KB (🟢 -12 B) 596.81 KB
/v3-migration 29.33 KB (🟡 +1 B) 604.46 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

@github-actions
Copy link

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 487.85 KB (🟡 +600 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Twelve Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 89.18 KB (🟡 +19 B) 577.02 KB
/500 16.46 KB (🟡 +1 B) 504.3 KB
/faucet 41.08 KB (🟡 +16 B) 528.93 KB
/governance 90.04 KB (🟡 +15 B) 577.89 KB
/governance/ipfs-preview 122.76 KB (🟡 +35 B) 610.61 KB
/governance/proposal 122.92 KB (🟡 +33 B) 610.77 KB
/governance/proposal/[proposalId] 77.54 KB (🟡 +33 B) 565.38 KB
/history 50.53 KB (🟡 +36 B) 538.38 KB
/markets 36.97 KB (🟡 +3 B) 524.82 KB
/reserve-overview 38.86 KB (🟡 +20 B) 526.71 KB
/staking 36.43 KB (🟡 +19 B) 524.28 KB
/v3-migration 48.29 KB (🟡 +4 B) 536.14 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@github-actions
Copy link

@github-actions
Copy link

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 489.43 KB (🟡 +1.32 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Thirteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 91.75 KB (🟡 +29 B) 581.17 KB
/404 16.26 KB (🟡 +2 B) 505.68 KB
/500 16.67 KB (🟡 +1 B) 506.1 KB
/faucet 42.57 KB (🟡 +28 B) 532 KB
/governance 90.26 KB (🟡 +27 B) 579.69 KB
/governance/ipfs-preview 123.11 KB (🟡 +27 B) 612.54 KB
/governance/proposal 123.27 KB (🟡 +27 B) 612.7 KB
/governance/proposal/[proposalId] 77.88 KB (🟡 +27 B) 567.31 KB
/history 50.68 KB (🟡 +27 B) 540.11 KB
/markets 37.02 KB (🟡 +2 B) 526.45 KB
/reserve-overview 40.58 KB (🟡 +28 B) 530 KB
/staking 36.89 KB (🟡 +26 B) 526.32 KB
/v3-migration 48.54 KB (🟡 +6 B) 537.96 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@github-actions
Copy link

@github-actions
Copy link

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 489.43 KB (🟡 +1.32 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Thirteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 91.75 KB (🟡 +29 B) 581.17 KB
/404 16.26 KB (🟡 +2 B) 505.68 KB
/500 16.67 KB (🟡 +1 B) 506.1 KB
/faucet 42.57 KB (🟡 +28 B) 532 KB
/governance 90.26 KB (🟡 +27 B) 579.69 KB
/governance/ipfs-preview 123.11 KB (🟡 +27 B) 612.54 KB
/governance/proposal 123.27 KB (🟡 +27 B) 612.7 KB
/governance/proposal/[proposalId] 77.88 KB (🟡 +27 B) 567.31 KB
/history 50.68 KB (🟡 +27 B) 540.11 KB
/markets 37.02 KB (🟡 +2 B) 526.45 KB
/reserve-overview 40.58 KB (🟡 +28 B) 530 KB
/staking 36.89 KB (🟡 +26 B) 526.32 KB
/v3-migration 48.54 KB (🟡 +6 B) 537.96 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@github-actions
Copy link

@github-actions
Copy link

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 489.43 KB (🟡 +1.32 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Thirteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 91.75 KB (🟡 +29 B) 581.17 KB
/404 16.26 KB (🟡 +2 B) 505.68 KB
/500 16.67 KB (🟡 +1 B) 506.1 KB
/faucet 42.57 KB (🟡 +28 B) 532 KB
/governance 90.26 KB (🟡 +27 B) 579.69 KB
/governance/ipfs-preview 123.11 KB (🟡 +27 B) 612.54 KB
/governance/proposal 123.27 KB (🟡 +27 B) 612.7 KB
/governance/proposal/[proposalId] 77.88 KB (🟡 +27 B) 567.31 KB
/history 50.68 KB (🟡 +27 B) 540.11 KB
/markets 37.02 KB (🟡 +2 B) 526.45 KB
/reserve-overview 40.58 KB (🟡 +28 B) 530 KB
/staking 36.89 KB (🟡 +26 B) 526.32 KB
/v3-migration 48.54 KB (🟡 +6 B) 537.96 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@github-actions
Copy link

MareskoY
MareskoY previously approved these changes Oct 25, 2023
@grothem
Copy link
Collaborator

grothem commented Oct 25, 2023

Link T-7615

Copy link

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 489.78 KB (🟡 +1.32 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Thirteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 91.81 KB (🟡 +28 B) 581.59 KB
/404 16.26 KB (🟡 +2 B) 506.04 KB
/500 16.67 KB (🟡 +1 B) 506.46 KB
/faucet 42.57 KB (🟡 +28 B) 532.35 KB
/governance 90.26 KB (🟡 +27 B) 580.04 KB
/governance/ipfs-preview 123.11 KB (🟡 +27 B) 612.89 KB
/governance/proposal 123.27 KB (🟡 +27 B) 613.05 KB
/governance/proposal/[proposalId] 77.88 KB (🟡 +27 B) 567.66 KB
/history 50.68 KB (🟡 +27 B) 540.46 KB
/markets 37.57 KB (🟡 +3 B) 527.35 KB
/reserve-overview 40.58 KB (🟡 +29 B) 530.36 KB
/staking 36.89 KB (🟡 +26 B) 526.67 KB
/v3-migration 48.54 KB (🟡 +6 B) 538.32 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

Copy link

Copy link

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 489.78 KB (🟡 +1.32 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Thirteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 91.81 KB (🟡 +28 B) 581.59 KB
/404 16.26 KB (🟡 +2 B) 506.04 KB
/500 16.67 KB (🟡 +1 B) 506.46 KB
/faucet 42.57 KB (🟡 +28 B) 532.35 KB
/governance 90.26 KB (🟡 +27 B) 580.04 KB
/governance/ipfs-preview 123.81 KB (🟡 +27 B) 613.59 KB
/governance/proposal 123.97 KB (🟡 +27 B) 613.75 KB
/governance/proposal/[proposalId] 78.58 KB (🟡 +27 B) 568.36 KB
/history 50.68 KB (🟡 +27 B) 540.46 KB
/markets 37.57 KB (🟡 +3 B) 527.35 KB
/reserve-overview 40.58 KB (🟡 +29 B) 530.36 KB
/staking 36.89 KB (🟡 +26 B) 526.67 KB
/v3-migration 48.54 KB (🟡 +6 B) 538.32 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@JoaquinBattilana JoaquinBattilana merged commit c21d715 into main Nov 27, 2023
25 checks passed
@JoaquinBattilana JoaquinBattilana deleted the feat/repay-bundle branch November 27, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants