Code

BUIDL GSM Integration#421

Code

Draft

yan-man wants to merge 70 commits intomainaave/gho-core:mainfrom feat/gsm-buidlaave/gho-core:feat/gsm-buidlCopy head branch name to clipboard

+4,418-2

Commits

Commits on Aug 30, 2024

• feat: skeleton for GsmConverter buyAsset

  yan-man

  committed
  ab52741

Commits on Sep 4, 2024

• fix: resolve compilation issues

  yan-man

  committed
  b102136

• feat: initialize interface

  yan-man

  committed
  dd74cc2

• refactor: move files to separate directory

  yan-man

  committed
  023a6b4

• fix: resolve interface function visibility

  yan-man

  committed
  750eb61

• test: initialize constructor unit test

  yan-man

  committed
  038e3be

• test: testRevertConstructorZeroAddressParams;

  yan-man

  committed
  c574b35

Commits on Sep 5, 2024

• test: initialize BUIDL-specific test GSM

  yan-man

  committed
  56ab408

• test: add check on buyAsset for minAmount

  yan-man

  committed
  5760379

• test: happy path for converter buyAsset

  yan-man

  committed
  bb08c59

• test: events testing + happy path buyAsset

  yan-man

  committed
  eb4a888

• test: test revert cases

  yan-man

  committed
  8ca6481

• fix: resolve tests involving facilitator due to new one added

  yan-man

  committed
  2942b36

• fix: resolve fuzz test input with zero address

  yan-man

  committed
  ebca6d7

• feat: rescueTokens implementation + tests

  yan-man

  committed
  cff5b1f

Commits on Sep 6, 2024

• fix: convert to Ownable

  yan-man

  committed
  4d2abe2

• fix: validate calculated ghoAmount matches ghoSold, reset approvals, enforce no remaining balance in converter

  yan-man

  committed
  2faf8a6

• test: create mockGSM to test unmatching gho amount case

  yan-man

  committed
  bc05a7d

• refactor: methods re-order

  yan-man

  committed
  0c1beb2

• refactor: rename mock

  Show description for 117eda8
  yan-man

  committed
  117eda8

• test: test coverage for remaining token balances

  yan-man

  committed
  4f4603c

• feat: init buyAssetWithSig

  yan-man

  committed
  1dbff49

Commits on Sep 7, 2024

• test: happy path test for buyAssetWithSig

  yan-man

  committed
  bce34e7

Commits on Sep 9, 2024

• test: simplify testBuyAssetWithSig, add testBuyAssetWithSigExactDeadline

  yan-man

  committed
  62657ee

• test: add testRevertBuyAssetWithSigExpiredSignature

  yan-man

  committed
  522ada9

• test: add testRevertBuyAssetWithSigInvalidSignature

  yan-man

  committed
  b60751d

• test: add testRevertBuyAssetWithSigInvalidAmount

  yan-man

  committed
  6d90a66

• test: refer to proper value for BUIDL gsm exposure

  yan-man

  committed
  ea90912

• test: resolve test assertion on remaining gsm gho balance

  yan-man

  committed
  c9140c5

• test: clean up assertion failure messages, reference different test variables

  yan-man

  committed
  14fc942

• refactor: code segmentation

  yan-man

  committed
  0ba7d24

• test: fuzz test on minAssetAmount values

  yan-man

  committed
  1d0e326

Commits on Sep 10, 2024

• feat: init sellAsset functionality with mock

  yan-man

  committed
  fdd0046

• refactor: rename vars, update docs

  yan-man

  committed
  4e40559

• test: add docs for mock redemption

  yan-man

  committed
  aa30e1b

• feat: skeleton for sellAsset implementation

  yan-man

  committed
  3b96732

• feat: add remappings for mocks

  yan-man

  committed
  d79ebde

• test: resolve test compilations with additional constructor param

  yan-man

  committed
  80a2c72

• test: happy path sellAsset emitting events

  yan-man

  committed
  2f94eaa

• test: add happy path sellAsset assertions

  yan-man

  committed
  206160e

• test: invalid redemption

  Show description for acc78ca
  yan-man

  committed
  acc78ca

• test: fail cases for sellAsset with invalid asset amounts, add mocks

  Show description for 59d7291
  yan-man

  committed
  59d7291

• refactor: rename redeemable asset to issued asset to be more correct

  yan-man

  committed
  71b8641

• test: declare new typehash specific for converter, init happy path sellAssetWithSig test

  yan-man

  committed
  43187e6

• refactor: reference mock contract directly

  Show description for cd76351
  yan-man

  committed
  cd76351

• refactor: re-order assertions

  Show description for cb7b33b
  yan-man

  committed
  cb7b33b

Commits on Sep 11, 2024

• test: fail cases for sellAssetWithSig

  yan-man

  committed
  15e862a

• refactor: capitalize variable name

  yan-man

  committed
  409944b

• refactor: use more precise variable reference

  yan-man

  committed
  7b96c4c

• test: add testRevertSellAssetWithSigInvalidAmount

  yan-man

  committed
  74da86e

• test: add testBuyAssetWithDonatedTokens

  yan-man

  committed
  f0c35fd

• test: add testSellAssetDonatedTokens

  yan-man

  committed
  57df1d7

• test: fuzz for donated token amounts

  yan-man

  committed
  4b1ed4e

• test: clean up var references and add testFuzzSellAssetMaxAmount

  yan-man

  committed
  fdc083e

• test: clean up var reference

  yan-man

  committed
  df84a21

• test: add fuzz tests, testRevertSellAssetWithSigInvalidNonce

  yan-man

  committed
  91fb7b9

• test: add testRevertBuyAssetWithSigInvalidNonce

  yan-man

  committed
  655b0b0

• test: remove mock test files from coverage

  yan-man

  committed
  d0f89f2

Commits on Sep 18, 2024

• fix: remove need to upgrade gsm to trigger error

  yan-man

  committed
  8a47c39

• Merge branch 'main' into feat/gsm-buidl

  yan-man

  committed
  6e208a2

Commits on Sep 24, 2024

• feat: init GsmConverter overview doc

  yan-man

  committed
  3d7cbb0

Commits on Sep 25, 2024

• test: reduce unneeded mock code for MockGsmFailedSellAssetRemainingGhoBalance

  yan-man

  committed
  feeda78

Commits on Oct 14, 2024

• refactor: rename subscription event

  yan-man

  committed
  53dc395

• test: resolve tests from event change, rename mock files to be BUIDL-specific

  yan-man

  committed
  b48a0be

• Merge branch 'main' into feat/gsm-buidl

  yan-man

  committed
  ae2dec4

• refactor: rename issuance to subscription

  yan-man

  committed
  72ee91d

• feat: add todo notes on subscription fees

  yan-man

  committed
  16a5d59

• fix: account for subscription fee, resolve tests, param names

  yan-man

  committed
  c943e73

Commits on Oct 15, 2024

• test: end prank

  yan-man

  committed
  0201eea

• fix: safe operations

  yan-man

  committed
  b11bfc6