Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GhoStewardV2.sol #402

Merged
merged 2 commits into from
May 27, 2024
Merged

Conversation

marczeller
Copy link
Contributor

  • Allowed GSM fees to be lowered

  • Allowed GSM exposure & borrow cap to be changed both ways

- Allowed GSM fees to be lowered

- Allowed GSM exposure & borrow cap to be changed both ways
Copy link

height bot commented May 21, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@marczeller
Copy link
Contributor Author

@JoaquinBattilana
Copy link
Member

JoaquinBattilana commented May 21, 2024

implementation looking good but can you please update the tests on TestGhoStewardV2.t.sol please?
They are failing because there are checks for the contract to be reverting when lowering the parameters
for example:

  function testRevertUpdateGhoBorrowCapIfValueLowerThanCurrent() public {
    uint256 oldBorrowCap = 1e6;
    _setGhoBorrowCapViaConfigurator(oldBorrowCap);
    vm.prank(RISK_COUNCIL);
    vm.expectRevert('INVALID_BORROW_CAP_UPDATE');
    GHO_STEWARD_V2.updateGhoBorrowCap(oldBorrowCap - 1);
  }

Also it would be good to have successful tests when lowering the parameters, and reverting when updating a value lower than allowed.

@miguelmtzinf
Copy link
Contributor

Please, update IGhoStewardV2 natspec docs to reflect the new changes.

@miguelmtzinf
Copy link
Contributor

Closes #401

@marczeller
Copy link
Contributor Author

@JoaquinBattilana did a separated PR for tests: #403

@miguelmtzinf miguelmtzinf changed the base branch from main to fix/aci-gho-steward May 27, 2024 10:18
@miguelmtzinf
Copy link
Contributor

Merged to a dedicated branch to consolidate all changes and trigger tests

@miguelmtzinf miguelmtzinf merged commit c441550 into aave:fix/aci-gho-steward May 27, 2024
0 of 30 checks passed
miguelmtzinf added a commit that referenced this pull request May 30, 2024
* Update GhoStewardV2.sol (#402)

- Allowed GSM fees to be lowered

- Allowed GSM exposure & borrow cap to be changed both ways

* fix: Fix certora specs for GhoSteward

---------

Co-authored-by: Marc Zeller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants