Chore/migration npm deps to forge #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
parth-15
force-pushed
the
chore/migration-npm-deps-to-forge
branch
from
fb2f625 to
3b02601
Compare
parth-15
force-pushed
the
chore/migration-npm-deps-to-forge
branch
from
3b02601 to
58cc954
Compare
PrinceRuler
approved these changes
Feb 8, 2024
| "overrides": { | ||
| "@nomicfoundation/hardhat-toolbox": { | ||
| "@nomiclabs/hardhat-ethers": "npm:hardhat-deploy-ethers" | ||
| "@nomiclabs/hardhat-ethers": "npm:hardhat-deploy-ethers@0.3.0-beta.13" |
There was a problem hiding this comment.
why this change is necessary? would prefer to avoid "beta" packages
There was a problem hiding this comment.
It is already using beta in existing implementation. I just highlighted it to make it more explicit. https://github.com/aave/gho-core/blob/main/package-lock.json#L11459-L11466
There was a problem hiding this comment.
Let's keep it as it is, given that there are compatibility issues between hardhat-deploy and hardhat-toolbox..,
miguelmtzinf
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.