test: add back borrow rate tests

aave · Aug 6, 2024 · df771f1 · df771f1
1 parent 2015f8c
commit df771f1
Show file tree

Hide file tree

Showing 2 changed files with 158 additions and 20 deletions.
diff --git a/src/contracts/misc/GhoAaveSteward.sol b/src/contracts/misc/GhoAaveSteward.sol
@@ -96,7 +96,7 @@ contract GhoAaveSteward is RiskCouncilControlled, IGhoAaveSteward {
   function updateGhoBorrowRate(
     /* TODO: Add all 4 parameters back */
     uint256 baseVariableBorrowRate
-  ) external onlyRiskCouncil notTimelocked(_ghoTimelocks.ghoBorrowCapLastUpdate) {
+  ) external onlyRiskCouncil notTimelocked(_ghoTimelocks.ghoBorrowRateLastUpdate) {
     _validateRatesUpdate(baseVariableBorrowRate);
     _updateRates(baseVariableBorrowRate);
 
@@ -191,7 +191,20 @@ contract GhoAaveSteward is RiskCouncilControlled, IGhoAaveSteward {
   }
 
   function _validateRatesUpdate(uint256 baseVariableBorrowRate) internal view {
-    (, uint256 currentBaseVariableBorrowRate, , ) = _getInterestRatesForAsset(GHO_TOKEN);
+    DataTypes.ReserveData memory ghoReserveData = IPool(
+      IPoolAddressesProvider(POOL_ADDRESSES_PROVIDER).getPool()
+    ).getReserveData(GHO_TOKEN);
+    require(
+      ghoReserveData.interestRateStrategyAddress != address(0),
+      'GHO_INTEREST_RATE_STRATEGY_NOT_FOUND'
+    );
+
+    (
+      uint256 optimalUsageRatio,
+      uint256 currentBaseVariableBorrowRate,
+      uint256 variableRateSlope1,
+      uint256 variableRateSlope2
+    ) = _getInterestRatesForAsset(GHO_TOKEN);
     require(
       _updateWithinAllowedRange(
         currentBaseVariableBorrowRate,
@@ -201,6 +214,15 @@ contract GhoAaveSteward is RiskCouncilControlled, IGhoAaveSteward {
       ),
       'INVALID_BORROW_RATE_UPDATE'
     );
+
+    uint256 maxBorrowRate = IDefaultInterestRateStrategyV2(
+      ghoReserveData.interestRateStrategyAddress
+    ).MAX_BORROW_RATE();
+    require(
+      uint256(baseVariableBorrowRate) + uint256(variableRateSlope1) + uint256(variableRateSlope2) <=
+        maxBorrowRate,
+      'BORROW_RATE_HIGHER_THAN_MAX'
+    );
   }
 
   /**

diff --git a/src/test/TestGhoAaveSteward.t.sol b/src/test/TestGhoAaveSteward.t.sol
@@ -282,6 +282,130 @@ contract TestGhoAaveSteward is TestGhoBase {
     assertEq(currentBorrowRate, newBorrowRate);
   }
 
+  function testUpdateGhoBorrowRateDownwards() public {
+    uint256 oldBorrowRate = _getGhoBorrowRate();
+    uint256 newBorrowRate = oldBorrowRate - 1;
+    vm.prank(RISK_COUNCIL);
+    GHO_AAVE_STEWARD.updateGhoBorrowRate(newBorrowRate);
+    uint256 currentBorrowRate = _getGhoBorrowRate();
+    assertEq(currentBorrowRate, newBorrowRate);
+  }
+
+  function testUpdateGhoBorrowRateMaxValue() public {
+    uint256 ghoBorrowRateMax = GHO_AAVE_STEWARD.GHO_BORROW_RATE_MAX() / 1e23;
+    _setGhoBorrowRateViaConfigurator(ghoBorrowRateMax - 1);
+    vm.prank(RISK_COUNCIL);
+    GHO_AAVE_STEWARD.updateGhoBorrowRate(ghoBorrowRateMax);
+    uint256 currentBorrowRate = _getGhoBorrowRate();
+    assertEq(currentBorrowRate, ghoBorrowRateMax);
+  }
+
+  function testUpdateGhoBorrowRateMaxIncrement() public {
+    uint256 oldBorrowRate = _getGhoBorrowRate();
+    uint256 newBorrowRate = oldBorrowRate + GHO_AAVE_STEWARD.GHO_BORROW_RATE_CHANGE_MAX() / 1e23;
+    vm.prank(RISK_COUNCIL);
+    GHO_AAVE_STEWARD.updateGhoBorrowRate(newBorrowRate);
+    uint256 currentBorrowRate = _getGhoBorrowRate();
+    assertEq(currentBorrowRate, newBorrowRate);
+  }
+
+  function testUpdateGhoBorrowRateDecrement() public {
+    uint256 oldBorrowRate = _getGhoBorrowRate();
+    uint256 newBorrowRate = oldBorrowRate - 1;
+    vm.prank(RISK_COUNCIL);
+    GHO_AAVE_STEWARD.updateGhoBorrowRate(newBorrowRate);
+    uint256 currentBorrowRate = _getGhoBorrowRate();
+    assertEq(currentBorrowRate, newBorrowRate);
+  }
+
+  function testUpdateGhoBorrowRateMaxDecrement() public {
+    vm.startPrank(RISK_COUNCIL);
+
+    // set a high borrow rate
+    GHO_AAVE_STEWARD.updateGhoBorrowRate(
+      _getGhoBorrowRate() + GHO_AAVE_STEWARD.GHO_BORROW_RATE_CHANGE_MAX() / 1e23
+    );
+    vm.warp(block.timestamp + GHO_AAVE_STEWARD.MINIMUM_DELAY() + 1);
+
+    uint256 oldBorrowRate = _getGhoBorrowRate();
+    uint256 newBorrowRate = oldBorrowRate - GHO_AAVE_STEWARD.GHO_BORROW_RATE_CHANGE_MAX() / 1e23;
+    GHO_AAVE_STEWARD.updateGhoBorrowRate(newBorrowRate);
+    uint256 currentBorrowRate = _getGhoBorrowRate();
+    assertEq(currentBorrowRate, newBorrowRate);
+
+    vm.stopPrank();
+  }
+
+  function testUpdateGhoBorrowRateTimelock() public {
+    uint256 oldBorrowRate = _getGhoBorrowRate();
+    vm.prank(RISK_COUNCIL);
+    GHO_AAVE_STEWARD.updateGhoBorrowRate(oldBorrowRate + 1);
+    IGhoAaveSteward.GhoDebounce memory ghoTimelocks = GHO_AAVE_STEWARD.getGhoTimelocks();
+    assertEq(ghoTimelocks.ghoBorrowRateLastUpdate, block.timestamp);
+  }
+
+  function testUpdateGhoBorrowRateAfterTimelock() public {
+    uint256 oldBorrowRate = _getGhoBorrowRate();
+    vm.prank(RISK_COUNCIL);
+    GHO_AAVE_STEWARD.updateGhoBorrowRate(oldBorrowRate + 1);
+    skip(GHO_AAVE_STEWARD.MINIMUM_DELAY() + 1);
+    uint256 newBorrowRate = oldBorrowRate + 2;
+    vm.prank(RISK_COUNCIL);
+    GHO_AAVE_STEWARD.updateGhoBorrowRate(newBorrowRate);
+    uint256 currentBorrowRate = _getGhoBorrowRate();
+    assertEq(currentBorrowRate, newBorrowRate);
+  }
+
+  function testRevertUpdateGhoBorrowRateIfUnauthorized() public {
+    vm.expectRevert('INVALID_CALLER');
+    vm.prank(ALICE);
+    GHO_AAVE_STEWARD.updateGhoBorrowRate(0.07e4);
+  }
+
+  function testRevertUpdateGhoBorrowRateIfUpdatedTooSoon() public {
+    uint256 oldBorrowRate = _getGhoBorrowRate();
+    vm.prank(RISK_COUNCIL);
+    uint256 newBorrowRate = oldBorrowRate + 1;
+    GHO_AAVE_STEWARD.updateGhoBorrowRate(newBorrowRate);
+    vm.prank(RISK_COUNCIL);
+    vm.expectRevert('DEBOUNCE_NOT_RESPECTED');
+    GHO_AAVE_STEWARD.updateGhoBorrowRate(newBorrowRate);
+  }
+
+  function testRevertUpdateGhoBorrowRateIfInterestRateNotFound() public {
+    uint256 oldBorrowRate = _getGhoBorrowRate();
+    DataTypes.ReserveData memory mockData = POOL.getReserveData(address(GHO_TOKEN));
+    mockData.interestRateStrategyAddress = address(0);
+    vm.mockCall(
+      address(POOL),
+      abi.encodeWithSelector(IPool.getReserveData.selector, address(GHO_TOKEN)),
+      abi.encode(mockData)
+    );
+    vm.expectRevert('GHO_INTEREST_RATE_STRATEGY_NOT_FOUND');
+    vm.prank(RISK_COUNCIL);
+    GHO_AAVE_STEWARD.updateGhoBorrowRate(oldBorrowRate + 1);
+  }
+
+  function testRevertUpdateGhoBorrowRateIfValueMoreThanMax() public {
+    address currentInterestRateStrategy = POOL.getReserveInterestRateStrategyAddress(
+      address(GHO_TOKEN)
+    );
+    uint256 maxGhoBorrowRate = IDefaultInterestRateStrategyV2(currentInterestRateStrategy)
+      .MAX_BORROW_RATE();
+    _setGhoBorrowRateViaConfigurator(maxGhoBorrowRate);
+    vm.prank(RISK_COUNCIL);
+    vm.expectRevert('BORROW_RATE_HIGHER_THAN_MAX');
+    GHO_AAVE_STEWARD.updateGhoBorrowRate(maxGhoBorrowRate + 1);
+  }
+
+  function testRevertUpdateGhoBorrowRateIfMaxExceededUpwards() public {
+    uint256 oldBorrowRate = _getGhoBorrowRate();
+    uint256 newBorrowRate = oldBorrowRate + GHO_AAVE_STEWARD.GHO_BORROW_RATE_CHANGE_MAX() + 1;
+    vm.prank(RISK_COUNCIL);
+    vm.expectRevert('INVALID_BORROW_RATE_UPDATE');
+    GHO_AAVE_STEWARD.updateGhoBorrowRate(newBorrowRate);
+  }
+
   function testRevertUpdateGhoBorrowRateIfMaxExceededDownwards() public {
     vm.startPrank(RISK_COUNCIL);
 
@@ -324,25 +448,17 @@ contract TestGhoAaveSteward is TestGhoBase {
     return configuration.getSupplyCap();
   }
 
-  function _setGhoBorrowRateViaConfigurator(
-    uint256 newBorrowRate
-  ) internal returns (GhoInterestRateStrategy, uint256) {
-    GhoInterestRateStrategy newRateStrategy = new GhoInterestRateStrategy(
-      address(PROVIDER),
-      newBorrowRate
-    );
-    CONFIGURATOR.setReserveInterestRateStrategyAddress(
-      address(GHO_TOKEN),
-      address(newRateStrategy)
-    );
-    address currentInterestRateStrategy = POOL.getReserveInterestRateStrategyAddress(
-      address(GHO_TOKEN)
-    );
-    uint256 currentBorrowRate = GhoInterestRateStrategy(currentInterestRateStrategy)
-      .getBaseVariableBorrowRate();
-    assertEq(currentInterestRateStrategy, address(newRateStrategy));
+  function _setGhoBorrowRateViaConfigurator(uint256 newBorrowRate) internal {
+    IDefaultInterestRateStrategyV2.InterestRateData
+      memory rateParams = IDefaultInterestRateStrategyV2.InterestRateData({
+        optimalUsageRatio: 1_00,
+        baseVariableBorrowRate: uint32(newBorrowRate),
+        variableRateSlope1: 0,
+        variableRateSlope2: 0
+      });
+    CONFIGURATOR.setReserveInterestRateParams(address(GHO_TOKEN), rateParams);
+    uint256 currentBorrowRate = _getGhoBorrowRate();
     assertEq(currentBorrowRate, newBorrowRate);
-    return (newRateStrategy, newBorrowRate);
   }
 
   function _getGhoBorrowRate() internal view returns (uint256) {