Merge pull request #208 from aave/fix/gho-token-cei-order

fix: Change order of GhoToken for CEI pattern
aave · Dec 15, 2022 · 6b84d1b · 6b84d1b
2 parents 17ffc03 + 3289293
commit 6b84d1b
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/contracts/gho/GhoToken.sol b/src/contracts/gho/GhoToken.sol
@@ -38,8 +38,9 @@ contract GhoToken is ERC20, Ownable, IGhoToken {
     require(bucketCapacity >= newBucketLevel, 'FACILITATOR_BUCKET_CAPACITY_EXCEEDED');
     _facilitators[msg.sender].bucketLevel = uint128(newBucketLevel);
 
-    emit FacilitatorBucketLevelUpdated(msg.sender, currentBucketLevel, newBucketLevel);
     _mint(account, amount);
+
+    emit FacilitatorBucketLevelUpdated(msg.sender, currentBucketLevel, newBucketLevel);
   }
 
   /**
@@ -50,11 +51,14 @@ contract GhoToken is ERC20, Ownable, IGhoToken {
    */
   function burn(uint256 amount) external override {
     require(amount != 0, 'INVALID_BURN_AMOUNT');
+
     uint256 currentBucketLevel = _facilitators[msg.sender].bucketLevel;
     uint256 newBucketLevel = currentBucketLevel - amount;
     _facilitators[msg.sender].bucketLevel = uint128(newBucketLevel);
-    emit FacilitatorBucketLevelUpdated(msg.sender, currentBucketLevel, newBucketLevel);
+
     _burn(msg.sender, amount);
+
+    emit FacilitatorBucketLevelUpdated(msg.sender, currentBucketLevel, newBucketLevel);
   }
 
   /// @inheritdoc IGhoToken