GHO CCIP 1.5 Token Pool #19
Conversation
|
contracts/src/v0.8/ccip/pools/GHO/UpgradeableBurnMintTokenPool.sol
Outdated
Show resolved
Hide resolved
| /// @param owner_ The address of the owner | ||
| /// @param allowlist A set of addresses allowed to trigger lockOrBurn as original senders | ||
| /// @param router The address of the router | ||
| function initialize(address owner_, address[] memory allowlist, address router) public virtual initializer { |
There was a problem hiding this comment.
We don't usually like putting _ in function params, suggested to use owner instead of owner_. Also @param comment to match
There was a problem hiding this comment.
yep normally i'd agree, it's actually done here because owner shadows a public method with the same name in the inherited ConfirmedOwnerWithProposal contract. can rename here since the shadow if a function with the same name, so should not cause any runtime issues; lemme know if you feel strongly about updating here, will do :)
| /// @param router The address of the router | ||
| /// @param bridgeLimit The maximum amount of tokens that can be bridged to other chains | ||
| function initialize( | ||
| address owner_, |
There was a problem hiding this comment.
Same as above comment on _ in variables
contracts/src/v0.8/ccip/test/pools/GHO/GhoTokenPoolEthereum.t.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/ccip/test/pools/GHO/GhoTokenPoolEthereum.t.sol
Outdated
Show resolved
Hide resolved
|
closing in favour of #20 |
No description provided.