-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply fixes based on code review #11
Conversation
|
4 similar comments
|
|
|
|
Go solidity wrappers are out-of-date, regenerate them via the |
LCOV of commit
|
@@ -58,9 +59,4 @@ contract UpgradeableBurnMintTokenPool is VersionedInitializable, UpgradeableBurn | |||
function REVISION() public pure virtual returns (uint256) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while this doesn't hurt it also doesn't help and is a bit useless when using Initializable
imo. I'd rather remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed, ty!
Go solidity wrappers are out-of-date, regenerate them via the |
LCOV of commit
|
After reviewing the changes, the fixes seem ok to me |
* feat: Add custom upgradeable TokenPool contracts * test: Add unit and e2e tests (#4) * test: Add unit and e2e tests * test: Add tests for bridge limit config * fix: Fix foundry toml * feat: Add Bridge limit admin (#6) * test: Add unit and e2e tests * test: Add tests for bridge limit config * fix: Fix foundry toml * feat: Add bridge limit admin * fix: Rename error * doc: Add caution docs to setBridgeLimit * fix: Fix github action dir name * fix: Add code diffs between custom token pools and standard implementation * fix: Directory restructure * fix: Fix README * fix: Remove unneccesary files * fix: fix README * test: Refactor invariant tests * test: Refactor tests * fix: Rename test files * Certora review (#10) * fix: Apply fixes based on code review (#11) * fix: Use modern version of Initializable * fix: Add event emission on bridge limit admin update * fix: Rebuild GHO diffs * fix: Remove unneeded revision getter * ci: Remove unneeded ci actions (#12) * fix: Use modern version of Initializable * fix: Update diffs * fix: Add event emission on bridge limit admin update --------- Co-authored-by: Nissan Levi <[email protected]>
BGD Labs review: https://governance.aave.com/t/arfc-gho-cross-chain-launch/17616/9